fix: Windows path bug in create-federation-tsconfig#79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78
This pull request improves the handling of file path separators in the
updateFederationTsConfigutility to ensure cross-platform compatibility, particularly for Windows environments. It also adds a new test to verify this behavior.Cross-platform path normalization:
src/tools/esbuild/create-federation-tsconfig.ts: Fixed the path normalization logic to replace single backslashes (This pull request improves the handling of file path separators in theupdateFederationTsConfig` utility to ensure cross-platform compatibility, particularly for Windows environments. It also adds a new test to verify this behavior.Cross-platform path normalization:
) with forward slashes (
/) when generating relative paths for theincludefield, ensuring compatibility across different operating systems.Testing improvements:
src/tools/esbuild/create-federation-tsconfig.spec.ts: Added a test case to verify that backslash path separators (common on Windows) are correctly normalized to forward slashes in the generatedtsconfigincludes.src/tools/esbuild/create-federation-tsconfig.spec.ts: Added a missing import for thepathmodule to support the new test.