Repository navigation
fix: re-export AssetRegistry from the react-native components shim - #504
Merged
Merged
Conversation
Contributor
|
@danstepanov can you run CI on this one? If it passes (no reason it shouldn't), we should merge. |
9 tasks done
mathiramilo
added a commit
to mathiramilo/football-club-management
that referenced
this pull request
Oct 25, 2026
…(TECH-15) NativeWind 5 (release candidate, on Tailwind v4 through react-native-css) reads the same packages/ui-tokens/theme.css as the web, so both apps share one token file. Metro sets rem to 16 px and keeps --club and --club-tint as runtime variables, which ClubTheme sets after the contrast guard; useClubTheme exposes the colors to platform controls such as Switch. Archivo loads at startup as three families with their weights, so font-sans, font-heading and font-display match the web. Text applies the family (native text doesn't inherit it) and caps display titles at 1.4x font scaling so wide titles don't break mid-word at 200%. Icon maps a lucide icon's text color and size from classes. Two release-candidate fixes: - @expo/metro-config's lightningcss is pinned to 1.30.1: react-native-css compiles with that copy and fails to deserialize 1.33's output. - react-native-css is patched to re-export React Native 0.88's AssetRegistry (upstream nativewind/react-native-css#504). Without it expo-asset gets undefined and every font load fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mathiramilo
added a commit
to mathiramilo/football-club-management
that referenced
this pull request
Oct 25, 2026
…(TECH-15) NativeWind 5 (release candidate, on Tailwind v4 through react-native-css) reads the same packages/ui-tokens/theme.css as the web, so both apps share one token file. Metro sets rem to 16 px and keeps --club and --club-tint as runtime variables, which ClubTheme sets after the contrast guard; useClubTheme exposes the colors to platform controls such as Switch. Archivo loads at startup as three families with their weights, so font-sans, font-heading and font-display match the web. Text applies the family (native text doesn't inherit it) and caps display titles at 1.4x font scaling so wide titles don't break mid-word at 200%. Icon maps a lucide icon's text color and size from classes. Two release-candidate fixes: - @expo/metro-config's lightningcss is pinned to 1.30.1: react-native-css compiles with that copy and fails to deserialize 1.33's output. - react-native-css is patched to re-export React Native 0.88's AssetRegistry (upstream nativewind/react-native-css#504). Without it expo-asset gets undefined and every font load fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
christophehurpeau
added a commit
to christophehurpeau/alouette
that referenced
this pull request
Nov 4, 2026
expo-asset 58 imports AssetRegistry from react-native (0.88), but react-native-css redirects react-native imports to a shim that does not forward it, crashing font loading on native. Remove once a release includes nativewind/react-native-css#504. Refs: nativewind/react-native-css#506
danstepanov
force-pushed
the
fix/export-asset-registry
branch
from
November 6, 2026 07:14
532e369 to
ee24ec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
AssetRegistryto thereact-native-css/componentsre-exports.Why
The Metro resolver sends
react-nativeimports fromnode_modulesto this file. React Native 0.88 addedAssetRegistryto its public exports, andexpo-assetdoesimport { AssetRegistry } from 'react-native'. Without this getter,expo-assetreceivesundefinedand every asset load fails:In an app this shows up as
useFontsfailing and the app silently falling back to system fonts.I compared the export list of
react-native/index.js(0.88.0) with this file.AssetRegistrywas the only name missing.Checked