Repository navigation
Accept Pathname as the local path for upload/download - #85
Merged
mfazekas merged 4 commits intoOct 22, 2026
Merged
Conversation
File objects also respond to to_path, so convert just Pathname to keep IO objects streamed as-is. Add upload/download tests for Pathname and File locals, and a changelog fragment.
mfazekas
changed the title
# Conflicts: # test/test_download.rb # test/test_upload.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert a
Pathnamelocal to its path string instart_command, so uploads read the file once instead of looping forever and downloads write every chunk instead of keeping only the last one. OnlyPathnameis converted:Fileobjects also respond toto_path, and they keep being used as IO (same approach as net-sftp #153). Adds upload/download tests forPathnameandFilelocals and a changelog fragment.Original fix by @OskarEichler.
Closes #29