Skip to content

fix(teams): allow hiding the shared folder button via config.php - #5641

Open
lennart441 wants to merge 2 commits into
stable8.7from
feat/hide-team-shared-folder-creation
Open

fix(teams): allow hiding the shared folder button via config.php#5641
lennart441 wants to merge 2 commits into
stable8.7from
feat/hide-team-shared-folder-creation

Conversation

@lennart441

@lennart441 lennart441 commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • Optionally hide the team-page button that creates a personal folder and shares it with the team, via a config.php flag.
  • Talk / Collective / Calendar shortcuts are unchanged. The Team Folder (groupfolders) path is unaffected.

Resolves: #5638

Config

'contacts.hide_team_shared_folder_creation' => true,
occ config:system:set contacts.hide_team_shared_folder_creation --type=boolean --value=true

Default remains false (button is shown).

Nextcloud 35

On Nextcloud 35 the teams frontend has moved to Circles, so this button no longer lives in Contacts (main):

This PR is the Contacts 8.7 counterpart for Nextcloud 33–34, where the team page is still in Contacts.

Backports

This targets stable8.7 (Nextcloud 33 and 34). Please also backport to:

  • stable8.3 — Nextcloud 32

/backport to stable8.3

Test plan

  • Fresh Nextcloud 34.0.2 stack with this Contacts branch
  • Open a team in Contacts: the Folder shortcut is visible by default
  • Set contacts.hide_team_shared_folder_creation to true, reload: Folder shortcut is gone; other Create actions remain
  • Set it back to false: Folder shortcut returns

Checklist

Default (show create button)
grafik

Now optional (no create button)
grafik

It is still possible to share a personal folder with a team.

AI (if applicable)

  • The content of this PR was partly generated using AI Model: Cursor Grok 4.6

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/CircleDetails.vue 0.00% 3 Missing ⚠️
src/services/hideTeamSharedFolderCreation.js 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Organizations that want Team Folders instead of personal shares can hide
the team-page action that creates a personal folder and shares it with
the team.

Fixes #5638

Assisted-by: Cursor Grok:cursor-grok-4.6
Signed-off-by: Lennart Joswig <mail@ljoswig.de>
Co-authored-by: Cursor <cursoragent@cursor.com>
@lennart441
lennart441 marked this pull request as ready for review August 13, 2026 08:28
@lennart441 lennart441 changed the title feat(teams): allow hiding the shared folder button via config.php fix(teams): allow hiding the shared folder button via config.php Aug 13, 2026
@lennart441
lennart441 force-pushed the feat/hide-team-shared-folder-creation branch from f897190 to 8eeea92 Compare August 13, 2026 08:28
@lennart441 lennart441 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 13, 2026
Comment thread lib/Controller/PageController.php Outdated
Switch the flag from a system config.php key to an app config so admins can set it with occ config:app:set.

Assisted-by: Cursor:Grok-4.6
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Lennart Joswig <mail@ljoswig.de>
@lennart441
lennart441 force-pushed the feat/hide-team-shared-folder-creation branch from decf4fd to 40d92b9 Compare August 25, 2026 11:55
@github-project-automation github-project-automation Bot moved this to Backlog in 👥 Teams Aug 26, 2026
@alimmroth alimmroth moved this from Backlog to In review in 👥 Teams Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants