Fix/restore teams UI version gated - #5669
Open
GVodyanov wants to merge 2 commits into
Open
Conversation
GVodyanov
requested review from
SebastianKrupinski and
hamza221
as code owners
August 25, 2026 17:28
GVodyanov
marked this pull request as draft
August 25, 2026 17:30
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
GVodyanov
commented
Aug 25, 2026
| // If circles is enabled let's init the store | ||
| if (isCirclesEnabled) { | ||
| // Only register the teams store when we manage teams ourselves | ||
| if (isTeamManagementEnabled) { |
Contributor
Author
There was a problem hiding this comment.
You may ask, why am I renaming this?
isCirclesEnabled used to check whether the circles "app" was installed and that's it, meanwhile isTeamManagementEnabled checks both if the app is installed and if the server version supports it. I figured seeing as it's a slightly different thing it would be best to separate the naming to not generate confusion
GVodyanov
marked this pull request as ready for review
August 25, 2026 17:38
This reverts commit d91b271. The team management UI was removed in preparation for the Teams app, but main serves Nextcloud 33 to 35. Once the app was updated on a 34 instance, teams could no longer be managed there at all. Restore the UI unchanged here; the following commit puts it behind a server version gate so it stays hidden on 35 and newer. Signed-off-by: Grigory Vodyanov <scratchx@gmx.com> Assisted-by: ClaudeCode:claude-opus-5
Teams are managed by the server itself from Nextcloud 35 on, so the app only renders its own team management UI up to 34. The existing isCirclesEnabled state now also requires that version and is renamed to isTeamManagementEnabled, so every call site says what it gates. The team route is only registered when the gate is open, because it depends on the circles store module that is registered under the same condition. Two pieces of the restored code were not put back verbatim: the UserGroupContent element referenced a component that does not exist, and the mounted hook read logger and the gate off the component instance where neither is a property, which threw on every load once the gate is closed. Signed-off-by: Grigory Vodyanov <scratchx@gmx.com> Assisted-by: ClaudeCode:claude-opus-5
GVodyanov
force-pushed
the
fix/restore-teams-ui-version-gated
branch
from
August 25, 2026 17:40
afeb555 to
9ff433f
Compare
ChristophWurst
approved these changes
Aug 26, 2026
ChristophWurst
left a comment
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Linked the reverted PR in the PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5635 and makes it conditional, because 34 and lower still need the UI.
🤖 AI (if applicable)