fix(entrypoint): compare enabled app names to report disabled apps after upgrade#2554
Open
joshtrichards wants to merge 1 commit intomasterfrom
Open
fix(entrypoint): compare enabled app names to report disabled apps after upgrade#2554joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
Extract the disabled-app reporting logic into a helper and compare normalized enabled app names instead of parsing diff output from full `occ app:list` snapshots. This fixes false positives where apps upgraded during `occ upgrade` were reported as disabled because their version line changed, and avoids reliance on diff output format differences on Alpine/BusyBox. Fixes #1911 Signed-off-by: Josh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor disabled-app reporting in
docker-entrypoint.shinto a helper and compare normalized enabled app names before and afterocc upgrade.Instead of diffing full
occ app:listoutput and parsing human-readablediffoutput, this change extracts only enabled app names and compares those sets directly.Why
The previous implementation had two problems:
False positives during upgrades
occ app:listchanged (for example due to a version bump), and the script treated that as a removal.Alpine / BusyBox incompatibility
diffoutput usinggrep '<', which does not work reliably with BusyBoxdiffoutput on Alpine.By comparing only enabled app names, the script now reports actual before-vs-after enablement changes instead of line-level text differences.
What changed
occ app:listoutput down to enabled app names onlycommBehavior before
calendar 4.2.2 -> 4.2.3could be reported as "disabled"diffoutput format differencesBehavior after
diffoutput formatNotes
This is both a cleanup and a bug fix:
not enabled after upgrade
Fixes #1911
Alternative to PR #2267