Media queue and Picture-in-Picture support#4032
Draft
s-kaliberda wants to merge 2 commits intonextcloud:stable-33.0.2from
Draft
Media queue and Picture-in-Picture support#4032s-kaliberda wants to merge 2 commits intonextcloud:stable-33.0.2from
s-kaliberda wants to merge 2 commits intonextcloud:stable-33.0.2from
Conversation
Signed-off-by: Serhii Kaliberda <[email protected]>
Collaborator
|
Hi @s-kaliberda, we will update you soon. |
Collaborator
|
Hi @s-kaliberda, would you mind writing an overview of how this implementation works, as well as what would be good to test. |
Collaborator
|
What do I have to do to enable PiP? I don't see an option for this .mov file. 
|
Contributor
Author
|
Hi. PiP doesn't work on iPhone simulator, use physical device or iPad simulator. |
Signed-off-by: Serhii Kaliberda <[email protected]>
Contributor
Author
|
@mpivchev I made a new commit with fixes to some bugs we found during our testing, please, pull the latest changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
After discussing media queue and Picture-in-Picture in the pull request, we agreed to use two libraries for media playback so that Picture-in-Picture will work. The media player uses AVKit for videos when the format is supported; otherwise, it uses MobileVLCKit.
This approach allowed us to preserve all existing functionality while also adding new features, such as a media queue for audio files and Picture-in-Picture for video files.
We implemented this logic in this pull request, and we’d like to hear your opinion on the implementation. Could you review the code and share your feedback?