feat(direct-editing): integrate with OCP\DirectEditing API#5656
Draft
juliusknorr wants to merge 3 commits into
Draft
feat(direct-editing): integrate with OCP\DirectEditing API#5656juliusknorr wants to merge 3 commits into
juliusknorr wants to merge 3 commits into
Conversation
Plug richdocuments into the server's shared Direct Editing API so
mobile apps (and any other clients) can open Collabora documents
through the standard /ocs/v2.php/apps/files/api/v1/directEditing/...
endpoints, alongside other editors registered via OCP\DirectEditing.
- Add OfficeDirectEditor (IEditor) and four ACreateFromTemplate
creators (document, spreadsheet, presentation, drawing) backed by
the existing TemplateManager and FileCreatedFromTemplateListener.
- Extract the user/file render branch of DirectViewController::show
into DirectEditingViewService so both the new IEditor::open path
and the legacy /direct/{token} webview share one implementation
(federation redirect, template-aware WOPI token, document template
response).
- Route the legacy OCS endpoints (/api/v1/document and
/api/v1/templates/new) through OCP\DirectEditing\IManager and mark
them deprecated; response shape unchanged.
- Keep the share/federation flows (/api/v1/share,
/api/v1/direct/share/initiator and the /direct/{token} webview)
untouched -- they have no equivalent in OCP\DirectEditing.
- Factor Capabilities mimetype dedup into helpers so the editor and
the capability advert read from one source of truth.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
force-pushed
the
feat/direct-editing-server-api
branch
from
44e955b to
b9f6568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plug richdocuments into the server's shared Direct Editing API so
mobile apps (and any other clients) can open Collabora documents
through the standard /ocs/v2.php/apps/files/api/v1/directEditing/...
endpoints, alongside other editors registered via OCP\DirectEditing.
creators (document, spreadsheet, presentation, drawing) backed by
the existing TemplateManager and FileCreatedFromTemplateListener.
into DirectEditingViewService so both the new IEditor::open path
and the legacy /direct/{token} webview share one implementation
(federation redirect, template-aware WOPI token, document template
response).
/api/v1/templates/new) through OCP\DirectEditing\IManager and mark
them deprecated; response shape unchanged.
/api/v1/direct/share/initiator and the /direct/{token} webview)
untouched -- they have no equivalent in OCP\DirectEditing.
the capability advert read from one source of truth.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com
Summary
TODO
Checklist