refactor(core): enhance BeforeMessageLoggedEventListener robustness and clarity #57281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd clarity Signed-off-by: Josh <[email protected]>
joshtrichards
added
feature: logging
♻️ refactor
joshtrichards
requested review from
leftybournes,
salmart-dev,
sorbaugh and
yemkareems
and removed request for
a team
Signed-off-by: Josh <[email protected]>
CarlSchwan
reviewed
Jan 2, 2026
Comment on lines
+99
to
+101
| // create a new instance of the current class and pass the desired log $level (from the CLI) options | ||
| $debugLoggerEventListener = new self($level); | ||
| // register a new event listener for the BeforeMessageLoggedEvent |
Member
There was a problem hiding this comment.
Suggested change
| // create a new instance of the current class and pass the desired log $level (from the CLI) options | |
| $debugLoggerEventListener = new self($level); | |
| // register a new event listener for the BeforeMessageLoggedEvent | |
| $debugLoggerEventListener = new self($level); |
I would say that this two comments are a bit useless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the CLI debug log listener by using ILogger constants, avoiding key errors, guarding to CLI only, and clarifying argument cleanup purpose with comments.
TODO
Checklist
3. to review, feature component)stable32)