Skip to content

[stable32] fix: Harmonize login and passwordless login redirect behavior #60009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backportbot wants to merge 5 commits into
base: stable32
Choose a base branch
from
+14 −7
Open

[stable32] fix: Harmonize login and passwordless login redirect behavior #60009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eadc9e9
fix: Always redirect to an absolute URL
come-nc Apr 21, 2026
aa67e6b
chore: Fix npm lint issues in PasswordLessLoginForm.vue
come-nc Apr 27, 2026
ee44bab
chore(assets): Recompile assets
nextcloud-command Apr 30, 2026
6cf0e66
chore: Fix lint error in PasswordLessLoginForm.vue
come-nc Apr 30, 2026
ac26c0c
chore(assets): Recompile assets
nextcloud-command Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions core/src/components/login/PasswordLessLoginForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
</template>

<script type="ts">
import { getBaseUrl } from '@nextcloud/router'
import { browserSupportsWebAuthn } from '@simplewebauthn/browser'
import { defineComponent } from 'vue'
import {
Expand Down Expand Up @@ -132,13 +133,19 @@ export default defineComponent({
this.$emit('update:username', this.user)
},
completeAuthentication(challenge) {
const redirectUrl = this.redirectUrl
let redirectUrl = this.redirectUrl

return finishAuthentication(challenge)
.then(({ defaultRedirectUrl }) => {
console.debug('Logged in redirecting')
// Redirect url might be false so || should be used instead of ??.
window.location.href = redirectUrl || defaultRedirectUrl
logger.debug('Logged in redirecting')
if (redirectUrl) {
if (redirectUrl.charAt(0) !== '/') {
redirectUrl = '/' + redirectUrl
}
window.location.href = getBaseUrl() + redirectUrl
} else {
window.location.href = defaultRedirectUrl
}
})
.catch(error => {
console.debug('GOT AN ERROR WHILE SUBMITTING CHALLENGE!')
Expand Down
4 changes: 2 additions & 2 deletions dist/core-login.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-login.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading