refactor(files_sharing): clarify password generation logic#61414
Draft
joshtrichards wants to merge 1 commit into
Draft
refactor(files_sharing): clarify password generation logic#61414joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up the file sharing
GeneratePassword.tsmodule to make the server-side and local password generation paths clearer, safer to read, and easier to reason about:generateLocalPassword()fillRandomValues()generateUrlandpasswordMath.floor()byte-to-index calculation based on the full 256-value byte range (0..255), which makes the bounds and intent clearer and avoids relying oncharAt()implicit float coercionThis is intended as a readability and maintainability cleanup rather than a meaningful behavior change. In particular, the byte-to-index refactor is a small correctness/readability improvement, not the sort of change that meaningfully alters the user-facing strength of generated passwords.
Notes
Math.random()as a last resort when the crypto API is unavailable. This remains intentionally compatible with the current behavior, but it is not cryptographically secure.While working on nextcloud-libraries/nextcloud-auth#950, I looked for other places where a similar cleanup would be relevant, which led to this PR.
Checklist
3. to review, feature component)stable32)AI (if applicable)