perf(View): don't sort twice the same array#61440
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
CarlSchwan
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
Improve performance a bit as this is in the hotpath and take ~2s in prod. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/findIn-mount-point
branch
from
94f1317 to
22d0ea3
Compare
CarlSchwan
changed the title
salmart-dev
approved these changes
Jun 19, 2026
Altahrim
approved these changes
Jun 19, 2026
Altahrim
left a comment
Altahrim
left a comment
Collaborator
There was a problem hiding this comment.
We should probably add it as a constraint for findIn. As a comment and/or as a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of findIn is already sorted as it use a binary search to create the array
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)