fix(files_trashbin): create folder if missing when expiring trash#61442
Open
invario wants to merge 1 commit into
Open
fix(files_trashbin): create folder if missing when expiring trash#61442invario wants to merge 1 commit into
invario wants to merge 1 commit into
Conversation
invario
requested review from
Altahrim,
ArtificialOwl,
CarlSchwan and
icewind1991
and removed request for
a team
8 tasks
invario
changed the title
|
The PR also solves the issue for NC 34 |
twrm
reviewed
Jun 19, 2026
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
invario
force-pushed
the
fix_files_trashbin_exception
branch
from
fa93943 to
359aeda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If the background job to expire trash was executed before a user had ever trashed a file, the
files_trashbinfolder would be missing and an exception was thrown. Change the method used fromgettogetOrCreateFolderinstead.Checklist
3. to review, feature component)stable32)