[stable33] fix(console): write app command loading errors to stderr - #62997
Open
backportbot[bot] wants to merge 1 commit into
Open
[stable33] fix(console): write app command loading errors to stderr#62997backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
backportbot
Bot
requested review from
AndyScherzinger,
artonge,
printminion-co and
susnux
August 7, 2026 04:56
backportbot
Bot
added
bug
3. to review
printminion-co
marked this pull request as ready for review
August 7, 2026 04:57
printminion-co
requested review from
Altahrim,
icewind1991,
provokateurin and
salmart-dev
and removed request for
a team
August 7, 2026 04:57
CarlSchwan
approved these changes
Aug 7, 2026
CarlSchwan
enabled auto-merge
August 7, 2026 06:09
AndyScherzinger
approved these changes
Aug 7, 2026
AndyScherzinger
force-pushed
the
backport/62718/stable33
branch
from
August 7, 2026 16:43
d6060a2 to
7ae0cc3
Compare
fix(console): write app command loading errors to stderr
When an app fails to load its commands from info.xml, the error was
written to stdout, while every other diagnostic in loadCommands() uses
$output->getErrorOutput(). The command itself then runs normally and
exits 0, so the message silently corrupts machine-readable output:
$ ./occ app:list --output=json
Connection refused
{"enabled":{...},"disabled":{...}}
$ echo $?
0
Anything piping `occ <cmd> --output=json` into a JSON parser breaks, with
no non-zero exit code to detect it by.
Observed with notify_push on a setup that has the phpredis extension
loaded but no Redis configured: RedisFactory::isAvailable() only checks
whether the extension is loaded, so constructing the app's console
commands ends up calling pconnect() and throws RedisException.
--no-warnings is not a workaround for this, as it sets VERBOSITY_QUIET
and suppresses the payload too.
Route the message to the error output instead. It is still reported via
logger->error() exactly as before.
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
artonge
force-pushed
the
backport/62718/stable33
branch
from
August 7, 2026 19:36
7ae0cc3 to
49743f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #62718
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.