Skip to content

fix(conversations): apply the selected preset's parameters when creating a conversation - #6649

Merged
mahibi merged 2 commits into
masterfrom
bugfix/noid/conversationCreationParameters
Sep 7, 2026
Merged

fix(conversations): apply the selected preset's parameters when creating a conversation#6649
mahibi merged 2 commits into
masterfrom
bugfix/noid/conversationCreationParameters

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Sep 4, 2026 •
edited by mahibi
Loading

Copy link
Copy Markdown
Member

The conversation creation screen sent only the preset identifier to the creation endpoint. That
endpoint derives just the conversation attributes from it and stores whatever parameters the request
carried, so the parameters of the selected conversation type never arrived:

  • Voice rooms were created neither listable nor expiring.
  • Channels and announcements granted call and media permissions (372) instead of reactions only
    (257), which contradicts our own nc_channel_description string.
  • The "allow guests" switch had no effect whatsoever: roomType was hardcoded to group, so no
    public conversation was ever created, and the password was then set on a private one.
  • The administrator configured defaults never reached a created conversation.

On top of that the redundant POST /listable after creation is gone, the voice room type is hidden
where calls are disabled server wide, and servers without conversation-creation-all are served by
follow-up requests instead of silently losing the participants, the description and the listable
state.

This is the first of three stacked PRs; the conversation types themselves move to the presets
endpoint in the follow-up.

🖼️ Screenshots

No visual change other than the voice room type being hidden where calls are disabled server wide,
so no before/after shots.

🚧 TODO

  • nothing outstanding

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Capabilities checked: conversation-creation-all, conversation-creation-password (added here),
conversation-presets, announcement-preset and config => call => enabled.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🤖 Generated with Claude Code

https://claude.ai/code/session_014YnDswTbCmRrVETnwE4twB

@AndyScherzinger AndyScherzinger mentioned this pull request Sep 4, 2026
Merged
7 tasks
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33898044737/artifacts/9946813233
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger added enhancement New feature or request 3. to review Waiting for reviews labels Sep 4, 2026
@AndyScherzinger
AndyScherzinger force-pushed the bugfix/noid/conversationCreationParameters branch from eb2dcca to b6bd25c Compare September 5, 2026 06:39
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33950426057/artifacts/9964745178
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
AndyScherzinger force-pushed the bugfix/noid/conversationCreationParameters branch from b6bd25c to 0d12eca Compare September 5, 2026 10:47
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33961731118/artifacts/9968253024
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
AndyScherzinger force-pushed the bugfix/noid/conversationCreationParameters branch from 0d12eca to 86afe4c Compare September 7, 2026 06:35
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/34091550865/artifacts/10007189181
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
mahibi self-requested a review September 7, 2026 09:01
@mahibi
mahibi force-pushed the bugfix/noid/conversationCreationParameters branch from 6f175b7 to f916e09 Compare September 7, 2026 09:01
@AndyScherzinger
fix(conversations): apply the selected preset's parameters when creat…
bfd84fb 
…ing a conversation

The creation screen sent only the preset identifier, but the endpoint derives
just the conversation attributes from it and stores whatever parameters the
request carried. Voice rooms were therefore neither listable nor expiring, and
channels granted call and media permissions instead of reactions only.

Allowing guests now sets the room type, so the switch creates a public
conversation instead of having no effect, and the password travels in the
creation request where the server supports it. Servers without
conversation-creation-all are served by follow up requests instead, which no
longer discard a conversation that was already created when one of them fails.

Assisted-by: Claude Code:claude-opus-5
Claude-Session: https://claude.ai/code/session_014YnDswTbCmRrVETnwE4twB
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the bugfix/noid/conversationCreationParameters branch from f916e09 to bfd84fb Compare September 7, 2026 09:21
mahibi
mahibi approved these changes Sep 7, 2026
View reviewed changes

@mahibi mahibi left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one commit.
lgtm+tested it

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/34105529188/artifacts/10012945676
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
refactor(conversations): decouple ConversationOption from password di…
ea4855b 
…alog state

RoomCreationOptions already knows whether it's rendering the "set
password" or "change password" row, so let it pass an onClick directly
instead of having ConversationOption re-infer the click target from
switch nullness and its own password state read.

Assisted-by: Claude Code:claude-sonnet-5

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
mahibi merged commit 7a7d495 into master Sep 7, 2026
14 of 18 checks passed
@mahibi
mahibi deleted the bugfix/noid/conversationCreationParameters branch September 7, 2026 14:00
@mahibi mahibi added this to the 25.1.0 milestone Sep 7, 2026
@mahibi

mahibi commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

/backport to stable-25.0.x

@backportbot backportbot Bot mentioned this pull request Sep 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews AI assisted enhancement New feature or request

Projects

None yet

Milestone

25.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyScherzinger @mahibi @ybanezhou777