enh/y indexeddb

.github/workflows/cypress-e2e.yml

@@ -170,6 +170,8 @@ jobs:
           php occ app:list
           php occ background:cron
           php occ config:system:set session_keepalive --value=false --type=boolean
+          # Set offline_readonly_delay to 5 seconds to speed up tests that rely on it, like recover tests in sync.spec.js
+          php occ config:app:set --type integer --value 5 text offline_readonly_delay
           curl -v http://localhost:8081/index.php/login
           cat data/nextcloud.log
 

.github/workflows/playwright.yml

@@ -14,54 +14,55 @@ jobs:
   test:
     timeout-minutes: 60
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        shardIndex: [1, 2, 3]
+        shardTotal: [3]
     steps:
       - name: Checkout app
-        uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
 
       - name: Check composer.json
         id: check_composer
-        uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
+        uses: andstor/file-existence-action@558493d6c74bf472d87c84eab196434afc2fa029 # v3.1.0
         with:
           files: 'composer.json'
 
       - name: Install composer dependencies
         if: steps.check_composer.outputs.files_exists == 'true'
         run: composer install --no-dev
 
-      - name: Read package.json node and npm engines version
-        uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
+      - name: Read package.json
+        uses: nextcloud-libraries/parse-package-engines-action@122ae05d4257008180a514e1ddeb0c1b9d094bdd # v0.1.0
         id: versions
-        with:
-          fallbackNode: '^20'
-          fallbackNpm: '^10'
 
-      - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
+      - name: Set up node
+        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
         with:
-          node-version: ${{ steps.versions.outputs.nodeVersion }}
+          node-version: ${{ steps.versions.outputs.node-version }}
 
-      - name: Set up npm ${{ steps.versions.outputs.npmVersion }}
-        run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
+      - name: Set up npm
+        run: npm i -g 'npm@${{ steps.versions.outputs.steps.versions.outputs.package-manager-version }}'
 
       - name: Install node dependencies & build app
         env:
           CYPRESS_INSTALL_BINARY: 0
         run: |
           npm ci
-          TESTING=true npm run build --if-present
+          npm run build --if-present
 
       - name: Install Playwright Browsers
         run: npx playwright install chromium --only-shell
 
       - name: Run Playwright tests
-        run: npx playwright test
+        run: npx playwright test --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
 
       - name: Upload results
-        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
-        if: always()
+        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
+        if: ${{ !cancelled() }}
         with:
-          name: playwright-report
+          name: playwright-report_shard${{ matrix.shardIndex }}
           path: test-results/
-          retention-days: 30
+          retention-days: 7

composer/composer/autoload_classmap.php

@@ -40,12 +40,12 @@
     'OCA\\Text\\Listeners\\BeforeAssistantNotificationListener' => $baseDir . '/../lib/Listeners/BeforeAssistantNotificationListener.php',
     'OCA\\Text\\Listeners\\BeforeNodeDeletedListener' => $baseDir . '/../lib/Listeners/BeforeNodeDeletedListener.php',
     'OCA\\Text\\Listeners\\BeforeNodeRenamedListener' => $baseDir . '/../lib/Listeners/BeforeNodeRenamedListener.php',
-    'OCA\\Text\\Listeners\\BeforeNodeWrittenListener' => $baseDir . '/../lib/Listeners/BeforeNodeWrittenListener.php',
     'OCA\\Text\\Listeners\\FilesLoadAdditionalScriptsListener' => $baseDir . '/../lib/Listeners/FilesLoadAdditionalScriptsListener.php',
     'OCA\\Text\\Listeners\\FilesSharingLoadAdditionalScriptsListener' => $baseDir . '/../lib/Listeners/FilesSharingLoadAdditionalScriptsListener.php',
     'OCA\\Text\\Listeners\\LoadEditorListener' => $baseDir . '/../lib/Listeners/LoadEditorListener.php',
     'OCA\\Text\\Listeners\\LoadViewerListener' => $baseDir . '/../lib/Listeners/LoadViewerListener.php',
     'OCA\\Text\\Listeners\\NodeCopiedListener' => $baseDir . '/../lib/Listeners/NodeCopiedListener.php',
+    'OCA\\Text\\Listeners\\NodeWrittenResetDocumentListener' => $baseDir . '/../lib/Listeners/NodeWrittenResetDocumentListener.php',
     'OCA\\Text\\Listeners\\RegisterDirectEditorEventListener' => $baseDir . '/../lib/Listeners/RegisterDirectEditorEventListener.php',
     'OCA\\Text\\Listeners\\RegisterTemplateCreatorListener' => $baseDir . '/../lib/Listeners/RegisterTemplateCreatorListener.php',
     'OCA\\Text\\Listeners\\VersionRestoredListener' => $baseDir . '/../lib/Listeners/VersionRestoredListener.php',

composer/composer/autoload_static.php

@@ -55,12 +55,12 @@ class ComposerStaticInitText
         'OCA\\Text\\Listeners\\BeforeAssistantNotificationListener' => __DIR__ . '/..' . '/../lib/Listeners/BeforeAssistantNotificationListener.php',
         'OCA\\Text\\Listeners\\BeforeNodeDeletedListener' => __DIR__ . '/..' . '/../lib/Listeners/BeforeNodeDeletedListener.php',
         'OCA\\Text\\Listeners\\BeforeNodeRenamedListener' => __DIR__ . '/..' . '/../lib/Listeners/BeforeNodeRenamedListener.php',
-        'OCA\\Text\\Listeners\\BeforeNodeWrittenListener' => __DIR__ . '/..' . '/../lib/Listeners/BeforeNodeWrittenListener.php',
         'OCA\\Text\\Listeners\\FilesLoadAdditionalScriptsListener' => __DIR__ . '/..' . '/../lib/Listeners/FilesLoadAdditionalScriptsListener.php',
         'OCA\\Text\\Listeners\\FilesSharingLoadAdditionalScriptsListener' => __DIR__ . '/..' . '/../lib/Listeners/FilesSharingLoadAdditionalScriptsListener.php',
         'OCA\\Text\\Listeners\\LoadEditorListener' => __DIR__ . '/..' . '/../lib/Listeners/LoadEditorListener.php',
         'OCA\\Text\\Listeners\\LoadViewerListener' => __DIR__ . '/..' . '/../lib/Listeners/LoadViewerListener.php',
         'OCA\\Text\\Listeners\\NodeCopiedListener' => __DIR__ . '/..' . '/../lib/Listeners/NodeCopiedListener.php',
+        'OCA\\Text\\Listeners\\NodeWrittenResetDocumentListener' => __DIR__ . '/..' . '/../lib/Listeners/NodeWrittenResetDocumentListener.php',
         'OCA\\Text\\Listeners\\RegisterDirectEditorEventListener' => __DIR__ . '/..' . '/../lib/Listeners/RegisterDirectEditorEventListener.php',
         'OCA\\Text\\Listeners\\RegisterTemplateCreatorListener' => __DIR__ . '/..' . '/../lib/Listeners/RegisterTemplateCreatorListener.php',
         'OCA\\Text\\Listeners\\VersionRestoredListener' => __DIR__ . '/..' . '/../lib/Listeners/VersionRestoredListener.php',

cypress/e2e/api/SessionApi.spec.js

@@ -73,34 +73,33 @@ describe('The session Api', function () {
 			cy.closeConnection(connection)
 		})
 
-		// Echoes all message types but queries
-		Object.entries(messages)
-			.filter(([key, _value]) => key !== 'query')
-			.forEach(([type, sample]) => {
-				it(`echos ${type} messages`, function () {
-					const steps = [sample]
-					const version = 0
-					cy.pushSteps({ connection, steps, version })
-						.its('version')
-						.should('eql', 0)
-					cy.syncSteps(connection)
-						.its('steps[0].data')
-						.should('eql', steps)
-				})
+		// Echoes updates and responses
+		;['update', 'response'].forEach((type) => {
+			it(`echos ${type} messages`, function () {
+				const steps = [messages[type]]
+				const version = 0
+				cy.pushSteps({ connection, steps, version })
+					.its('version')
+					.should('eql', 0)
+				cy.syncSteps(connection).its('steps[0].data').should('eql', steps)
 			})
+		})
 
-		it('responds to queries', function () {
+		it('responds to queries with updates and responses', function () {
 			const version = 0
 			Object.entries(messages).forEach(([type, sample]) => {
 				cy.pushSteps({ connection, steps: [sample], version })
 			})
 			cy.pushSteps({ connection, steps: [messages.query], version }).then(
 				(response) => {
 					cy.wrap(response).its('version').should('eql', 0)
-					cy.wrap(response).its('steps.length').should('eql', 1)
+					cy.wrap(response).its('steps.length').should('eql', 2)
 					cy.wrap(response)
 						.its('steps[0].data')
 						.should('eql', [messages.update])
+					cy.wrap(response)
+						.its('steps[1].data')
+						.should('eql', [messages.response])
 				},
 			)
 		})
@@ -111,7 +110,6 @@ describe('The session Api', function () {
 		let connection
 		let fileId
 		let filePath
-		let joining
 
 		beforeEach(function () {
 			cy.testName().then((name) => {
@@ -156,13 +154,10 @@ describe('The session Api', function () {
 				manualSave: true,
 			})
 			cy.openConnection({ fileId, filePath })
-				.then(({ connection: con, data }) => {
-					joining = con
-					return data
-				})
-				.its('documentState')
+				.as('joining')
+				.its('data.documentState')
 				.should('eql', documentState)
-			cy.closeConnection(joining)
+			cy.get('@joining').its('connection').then(cy.closeConnection)
 		})
 
 		afterEach(function () {
@@ -175,7 +170,6 @@ describe('The session Api', function () {
 		let connection
 		let filePath
 		let shareToken
-		let joining
 
 		beforeEach(function () {
 			cy.testName().then((name) => {
@@ -232,13 +226,10 @@ describe('The session Api', function () {
 				manualSave: true,
 			})
 			cy.openConnection({ filePath: '', token: shareToken })
-				.then(({ connection: con, data }) => {
-					joining = con
-					return data
-				})
-				.its('documentState')
+				.as('joining')
+				.its('data.documentState')
 				.should('eql', documentState)
-			cy.closeConnection(joining)
+			cy.get('@joining').its('connection').then(cy.closeConnection)
 		})
 	})
 

cypress/e2e/api/SyncServiceProvider.spec.js

@@ -43,15 +43,20 @@ describe('Sync service provider', function () {
 	 */
 	function createProvider(ydoc) {
 		const relativePath = '.'
-		const { connection, openConnection, baseVersionEtag } = provideConnection({
-			fileId,
-			relativePath,
-		})
-		const { syncService } = provideSyncService(
-			connection,
-			openConnection,
-			baseVersionEtag,
+		let baseVersionEtag
+		const setBaseVersionEtag = (val) => {
+			baseVersionEtag = val
+		}
+		const getBaseVersionEtag = () => baseVersionEtag
+		const { connection, openConnection } = provideConnection(
+			{
+				fileId,
+				relativePath,
+			},
+			getBaseVersionEtag,
+			setBaseVersionEtag,
 		)
+		const { syncService } = provideSyncService(connection, openConnection)
 		const queue = []
 		syncService.bus.on('opened', () => syncService.startSync())
 		return createSyncServiceProvider({