Skip to content

feat: gridss/annotate nf-core module#11117

Merged
emmcauley merged 6 commits intonf-core:masterfrom
fulcrumgenomics:em_gridss_annotate
Apr 9, 2026
Merged

feat: gridss/annotate nf-core module#11117
emmcauley merged 6 commits intonf-core:masterfrom
fulcrumgenomics:em_gridss_annotate

Conversation

@emmcauley
Copy link
Copy Markdown
Contributor

This PR adds gridss/annotate and mirrors the structure of other gridss/ nf-core modules. Tests are added.

PR checklist

Closes #8422

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@emmcauley emmcauley force-pushed the em_gridss_annotate branch 2 times, most recently from 2c37273 to d526719 Compare April 2, 2026 21:13
@emmcauley emmcauley requested review from a team as code owners April 2, 2026 21:13
@emmcauley emmcauley force-pushed the em_gridss_annotate branch 2 times, most recently from a383b82 to bee6c7e Compare April 4, 2026 18:22
@emmcauley emmcauley force-pushed the em_gridss_annotate branch from bee6c7e to add37aa Compare April 4, 2026 23:05
Copy link
Copy Markdown
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to nf-core! We really appreciate it. I added a few comments to your PR. Looks good already.

@emmcauley emmcauley force-pushed the em_gridss_annotate branch 4 times, most recently from e78df91 to 34cff9c Compare April 8, 2026 18:13
@emmcauley emmcauley force-pushed the em_gridss_annotate branch from 34cff9c to cb107a5 Compare April 8, 2026 18:50
@emmcauley emmcauley requested review from SPPearce and famosab April 8, 2026 19:50
@emmcauley emmcauley requested review from famosab and mashehu April 9, 2026 15:50
@emmcauley emmcauley added this pull request to the merge queue Apr 9, 2026
Merged via the queue into nf-core:master with commit 071d7b4 Apr 9, 2026
124 of 129 checks passed
@emmcauley emmcauley deleted the em_gridss_annotate branch April 9, 2026 20:47
@emmcauley emmcauley added the new module Adding a new module label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new module Adding a new module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: gridss/annotate

4 participants