Skip to content

Update KAIJU_MKFMI to also emit another taxonomy file required downstream#11172

Open
jfy133 wants to merge 9 commits intonf-core:masterfrom
jfy133:master
Open

Update KAIJU_MKFMI to also emit another taxonomy file required downstream#11172
jfy133 wants to merge 9 commits intonf-core:masterfrom
jfy133:master

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Apr 14, 2026

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@sofstam
Copy link
Copy Markdown
Contributor

sofstam commented Apr 14, 2026

The linting needs to be fixed before merging

@jfy133 jfy133 marked this pull request as draft April 14, 2026 07:43
@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Apr 14, 2026

Have a similar issue for KMCP so will try and wrap into one

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Apr 15, 2026

Will do KMCP in a separate PR

@jfy133 jfy133 marked this pull request as ready for review April 15, 2026 11:20
@jfy133 jfy133 added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants