Skip to content

Add/flashpca#11194

Open
dbaku42 wants to merge 11 commits intonf-core:masterfrom
dbaku42:add/flashpca
Open

Add/flashpca#11194
dbaku42 wants to merge 11 commits intonf-core:masterfrom
dbaku42:add/flashpca

Conversation

@dbaku42
Copy link
Copy Markdown

@dbaku42 dbaku42 commented Apr 15, 2026

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

donald and others added 11 commits March 26, 2026 15:35
- Updated nf-test snapshots
- Small changes to main.nf and meta.yml
- Updated bcftools/filter and plink2/vcf related files
- Added flashpca module using custom container ghcr.io/dbaku42/flashpca:2.0
- Fixed file handling for PLINK inputs inside Docker (cp -L + fixed basename)
- Updated nf-test to use proper input tuple
- Test now passes with --profile docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant