Skip to content

diamond/deepclust#11195

Open
vagkaratzas wants to merge 2 commits intomasterfrom
add-diamond_deepclust
Open

diamond/deepclust#11195
vagkaratzas wants to merge 2 commits intomasterfrom
add-diamond_deepclust

Conversation

@vagkaratzas
Copy link
Copy Markdown
Contributor

@vagkaratzas vagkaratzas commented Apr 15, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Copy Markdown
Contributor

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things


output:
tuple val(meta), path("*.tsv"), emit: clusters
tuple val("${task.process}"), val('diamond'), eval("diamond --version | sed 's/diamond version //g'"), emit: versions_diamond, topic: versions
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tuple val("${task.process}"), val('diamond'), eval("diamond --version | sed 's/diamond version //g'"), emit: versions_diamond, topic: versions
tuple val("${task.process}"), val('diamond'), eval("diamond --version | sed 's/.* //g'"), emit: versions_diamond, topic: versions

Look I'm usefull

"""
diamond \\
deepclust \\
${args} \\
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${args} \\
${args} \\
--memory-limit "${task.memory.toGiga()}" \\

From cli:
--memory-limit Memory limit in GB (default = 16G)

${args} \\
-p ${task.cpus} \\
--db ${fasta} \\
--out ${prefix}.tsv
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think ur also missing an optional output file. Think we might need to add a save_aln input arg

--aln-out                Output file for clustering alignments

description: Input protein FASTA file to be clustered
pattern: "*.{fa,faa,fasta,fa.gz,faa.gz,fasta.gz}"
ontologies:
- edam: http://edamontology.org/format_1929 # FASTA
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aww yeah with comments :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants