Skip to content

Apply review comments#301

Merged
kubranarci merged 7 commits intodevfrom
apply-review-comments
Apr 22, 2026
Merged

Apply review comments#301
kubranarci merged 7 commits intodevfrom
apply-review-comments

Conversation

@kubranarci
Copy link
Copy Markdown
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantbenchmarking branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@kubranarci kubranarci changed the base branch from master to dev April 21, 2026 16:13
@kubranarci
Copy link
Copy Markdown
Contributor Author

@nf-core-bot fix linting

Comment thread workflows/variantbenchmarking.nf Outdated
Comment thread workflows/variantbenchmarking.nf Outdated
@jfy133 jfy133 mentioned this pull request Apr 22, 2026
11 tasks
kubranarci and others added 4 commits April 22, 2026 10:18
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@kubranarci kubranarci merged commit 8bcf795 into dev Apr 22, 2026
20 checks passed
@kubranarci kubranarci deleted the apply-review-comments branch April 22, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants