fix(legacy-html): prevent scroll jump when opening header pickers#773
fix(legacy-html): prevent scroll jump when opening header pickers#773Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Adds a null check and a Reviewed by Cursor Bugbot for commit d6a4bff. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
=======================================
Coverage 78.43% 78.44%
=======================================
Files 157 157
Lines 13962 13967 +5
Branches 1152 1152
=======================================
+ Hits 10951 10956 +5
Misses 3006 3006
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Fixes an unintended page scroll jump when opening sticky header picker dropdowns in legacy HTML docs.
Validation
I reproduced and verified on a generated legacy HTML page (out/fs.html) and in browser behavior matching the reported scenario.
Reproduction steps
Open an API docs page.
Scroll to the middle of the page.
Open sticky header pickers (Table of contents, Index, Other versions, Options).
Before
Screen.Recording.2026-04-15.at.11.01.24.PM.mov
Opening a picker causes the page to jump upward unexpectedly.
After
Screen.Recording.2026-04-15.at.11.02.03.PM.mov
Opening a picker no longer changes scroll position; only the dropdown opens.
Related Issues
Fixes #764
Check List
node --run testand all tests passed.node --run format&node --run lint.