fix(web): shorten method labels in sidebar#798
Conversation
PR SummaryLow Risk Overview Before layout is built, ToC labels for callables now use Reviewed by Cursor Bugbot for commit 217358a. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
==========================================
+ Coverage 84.79% 84.99% +0.20%
==========================================
Files 177 179 +2
Lines 16174 16404 +230
Branches 1459 1482 +23
==========================================
+ Hits 13715 13943 +228
- Misses 2449 2451 +2
Partials 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
avivkeller
left a comment
There was a problem hiding this comment.
These are intentionally expanded, since the short version credits scenarios were multiple headings have the same navigation entry.
The correct approach to shortening these would be to revert the change that expanded them, and consolidate duplicate ToC entries into one.
|
cc @nodejs/web-infra I believe the intentional expansion is the method of choice, as it doesn't risk losing any important information, wdyt? |
|
Ping. The current proposal keeps the unique entries short and only expands when there would be conflicts. There should be no question about the improvement to legibility, clarity, and usability. |
2e28a03 to
217358a
Compare
avivkeller
left a comment
There was a problem hiding this comment.
give me a moment to make a sense

The TOCs are barely usable when methods include their possibly many parameters.