build, doc: use new api doc tooling#57343
Conversation
|
Review requested:
|
77ede22 to
3423c21
Compare
3423c21 to
451f8a7
Compare
cf2609b to
a3ce99d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57343 +/- ##
==========================================
+ Coverage 89.72% 89.73% +0.01%
==========================================
Files 675 676 +1
Lines 204797 206069 +1272
Branches 39344 39519 +175
==========================================
+ Hits 183752 184919 +1167
+ Misses 13324 13302 -22
- Partials 7721 7848 +127 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ovflowd
left a comment
There was a problem hiding this comment.
This is the result of many months of arduous work between many awesome folks, including @flakey5 @AugustinMauroy @araujogui @ovflowd @avivkeller and others.
I'm so proud of what we are achieving here and this is a huge step towards a modern tooling and a revamped API docs within Node.js
Approving, as I believe this is ready!
This comment was marked as resolved.
This comment was marked as resolved.
|
I've resolved all the runner failures except for a few on Windows. I'll look at those today, we are going to get this merged! |
|
There's quite honestly nothing else that could possibly fail |
|
Landed in 76215dc |
|
On a serious note, how far back are we intending this to land? |
It's a flake, and is not related to the changes in this PR. The test flaked twice before passing on it's third trial. See #61762 |
The plan is for this to land on all release lines, and immediately replace the existing documentation generation tooling, starting at the next patch release. |
|
There are some regressions in the JSON output (#57343 (comment)), let's not rush the backports |


Switches over to using the new doc generation tooling. For more background on this, please see #52343
Currently a draft just to get feedback on the approach to this integration.cc @nodejs/web-infra
Notable Change info (by @avivkeller):
The Node.js Website and Website Infrastructure teams have introduced a brand-new documentation pipeline, modernizing how our API docs are generated. While the documentation site may look familiar today, we are hard at work making a completely refreshed user interface in the very near future!