src: add a native mode to monitorEventLoopDelay#62934
Closed
rochdev wants to merge 5 commits intonodejs:mainfrom
Closed
src: add a native mode to monitorEventLoopDelay#62934rochdev wants to merge 5 commits intonodejs:mainfrom
rochdev wants to merge 5 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
c++
Contributor
Author
|
Duplicate of #62935 without removing the JS implementation if that's preferred. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62934 +/- ##
==========================================
+ Coverage 89.61% 89.63% +0.02%
==========================================
Files 706 706
Lines 219218 219324 +106
Branches 42002 42022 +20
==========================================
+ Hits 196446 196597 +151
+ Misses 14666 14619 -47
- Partials 8106 8108 +2
🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing in favor of #62935 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a native mode to
monitorEventLoopDelay. The JavaScript implementation is inaccurate and has a completely invalid count. When using the native mode, the resolution is ignored since by hooking into libuv a timer is not needed.