crypto: runtime-deprecate calling Hmac.digest() more than once (DEP0206)

doc/api/deprecations.md

@@ -4562,12 +4562,15 @@ removed in a future version of Node.js.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/63162
+    description: Runtime deprecation.
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/63121
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only
+Type: Runtime
 
 Calling `hmac.digest()` more than once returns an empty buffer instead of
 throwing an error. This behavior is inconsistent with `hash.digest()` and

lib/internal/crypto/hash.js

@@ -87,6 +87,13 @@ const maybeEmitDeprecationWarning = getDeprecationWarningEmitter(
   },
 );
 
+const emitHmacDoubleDigestDeprecation = getDeprecationWarningEmitter(
+  'DEP0206',
+  'Calling digest() on an already-finalized Hmac instance is deprecated.',
+  undefined,
+  false,
+);
+
 function Hash(algorithm, options) {
   if (!new.target)
     return new Hash(algorithm, options);
@@ -183,6 +190,7 @@ Hmac.prototype.digest = function digest(outputEncoding) {
   const state = this[kState];
 
   if (state[kFinalized]) {
+    emitHmacDoubleDigestDeprecation();
     const buf = Buffer.from('');
     if (outputEncoding && outputEncoding !== 'buffer')
       return buf.toString(outputEncoding);

test/parallel/test-crypto-dep0206.js

@@ -0,0 +1,19 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const { createHmac } = require('crypto');
+
+common.expectWarning({
+  DeprecationWarning: {
+    DEP0206: 'Calling digest() on an already-finalized Hmac instance is deprecated.',
+  },
+});
+
+const hmac = createHmac('sha256', 'key').update('data');
+hmac.digest();
+const second = hmac.digest();
+assert.deepStrictEqual(second, Buffer.from(''));

test/parallel/test-crypto-hmac.js

@@ -1,3 +1,3 @@
 'use strict';
 const common = require('../common');
 if (!common.hasCrypto) {
@@ -7,6 +7,12 @@
 const assert = require('assert');
 const crypto = require('crypto');
 
+common.expectWarning({
+  DeprecationWarning: {
+    DEP0206: 'Calling digest() on an already-finalized Hmac instance is deprecated.',
+  },
+});
+
 {
   const Hmac = crypto.Hmac;
   const instance = crypto.Hmac('sha256', 'Node');