crypto: move DEP0203 and DEP0204 to End-of-Life#63188
Draft
panva wants to merge 1 commit intonodejs:mainfrom
Draft
crypto: move DEP0203 and DEP0204 to End-of-Life#63188panva wants to merge 1 commit intonodejs:mainfrom
panva wants to merge 1 commit intonodejs:mainfrom
Conversation
panva
added
semver-major
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
Moves support for passing CryptoKey instances to node:crypto APIs to End-of-Life status (DEP0203). Moves support for passing a non-extractable CryptoKey instances to KeyObject.from() End-of-Life status (DEP0204). Closes nodejs#55293 Signed-off-by: Filip Skokan <[email protected]>
Member
Author
|
Not wanting to cause unnecessary churn and cause backport needs for 26.x i'll leave this in draft form until we start with v27.x alphas. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63188 +/- ##
==========================================
+ Coverage 90.04% 90.06% +0.01%
==========================================
Files 713 713
Lines 224926 224899 -27
Branches 42525 42527 +2
==========================================
+ Hits 202526 202545 +19
+ Misses 14180 14136 -44
+ Partials 8220 8218 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves support for passing CryptoKey instances to node:crypto APIs to End-of-Life status (DEP0203).
Moves support for passing a non-extractable CryptoKey instances to KeyObject.from() to End-of-Life status (DEP0204).
Closes #55293
doc-deprecation is since 24
runtime-deprecation is since 26
this eol is for 27
Moving DEP0204 to EOL in combination with the refactors done in #62924 and #63111 makes non-extractable CryptoKey instances actually non-extractable inside the Node.js process (barring --expose-internals 🤷♂️)