test: migrate buffer encoding tests to node:test#63245
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
needs-ci
lpinca
requested changes
May 11, 2026
Member
lpinca
left a comment
lpinca
left a comment
There was a problem hiding this comment.
Sorry but I think there is no added value here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #47707
Migrate two small legacy script-style parallel tests to
node:test:test-buffer-badhex.jstest-bad-unicode.jsThe assertions and behavior are unchanged; the test bodies are wrapped in named
test()calls.Validation:
node --test test/parallel/test-buffer-badhex.js test/parallel/test-bad-unicode.jsnode -c test/parallel/test-buffer-badhex.jsnode -c test/parallel/test-bad-unicode.jsnode tools/eslint/node_modules/eslint/bin/eslint.js test/parallel/test-buffer-badhex.js test/parallel/test-bad-unicode.jsI could not run the project
tools/test.pyharness in this checkout because there is no builtnode.exepresent.