Skip to content

dns: do not consult hosts file in reverse lookups#64268

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:fix
Open

dns: do not consult hosts file in reverse lookups#64268
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:fix

Conversation

@Archkon

@Archkon Archkon commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64257

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Jul 3, 2026
@Renegade334 Renegade334 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 3, 2026
@Renegade334

Copy link
Copy Markdown
Member

Marking as semver-major (happy to be overruled). Although we do state in the small print that .reverse() shouldn't interrogate the hosts file, it feels like there's a decent chance of something out there relying on this behaviour.

@Archkon

Archkon commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@Renegade334 How about using baking-for-lts label and ship to assess the impact? like this pr: #64114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dns.reverse uses /etc/hosts, but not the first entry

3 participants