Skip to content

doc: remove unsupported syntax from stream_iter.md#64649

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:stream_iter-no-ts-syntax
Jul 24, 2026
Merged

doc: remove unsupported syntax from stream_iter.md#64649
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:stream_iter-no-ts-syntax

Conversation

@aduh95

@aduh95 aduh95 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Our tooling does not deal well with Iterable<Uint8Array> syntax

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 21, 2026
aduh95 added a commit to aduh95/node that referenced this pull request Jul 21, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 22, 2026
aduh95 added a commit to aduh95/node that referenced this pull request Jul 22, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
aduh95 added a commit to aduh95/node that referenced this pull request Jul 22, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
aduh95 added a commit to aduh95/node that referenced this pull request Jul 22, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
aduh95 added a commit to aduh95/node that referenced this pull request Jul 22, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
aduh95 added a commit to aduh95/node that referenced this pull request Jul 22, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
aduh95 added a commit to aduh95/node that referenced this pull request Jul 22, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
aduh95 added a commit to aduh95/node that referenced this pull request Jul 22, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64649
✔  Done loading data for nodejs/node/pull/64649
----------------------------------- PR info ------------------------------------
Title      doc: remove unsupported syntax from `stream_iter.md` (#64649)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:stream_iter-no-ts-syntax -> nodejs:main
Labels     doc, author ready
Commits    2
 - doc: remove unsupported syntax from `stream_iter.md`
 - fixup! doc: remove unsupported syntax from `stream_iter.md`
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64649
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64649
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 21 Jul 2026 10:26:55 GMT
   ✔  Approvals: 2
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/64649#pullrequestreview-4744530150
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64649#pullrequestreview-4749903155
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 64649
From https://github.com/nodejs/node
 * branch                  refs/pull/64649/merge -> FETCH_HEAD
✔  Fetched commits as 594d0c562c48..53a84be593c0
--------------------------------------------------------------------------------
[main bd643ed512] doc: remove unsupported syntax from `stream_iter.md`
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Tue Jul 21 12:22:45 2026 +0200
 1 file changed, 34 insertions(+), 37 deletions(-)
Auto-merging doc/type-map.json
CONFLICT (content): Merge conflict in doc/type-map.json
error: could not apply 53a84be593... fixup! doc: remove unsupported syntax from `stream_iter.md`
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/30001920265

@jasnell

jasnell commented Jul 23, 2026

Copy link
Copy Markdown
Member

This will need a rebase

@jakecastelli jakecastelli removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 23, 2026
aduh95 added a commit to aduh95/node that referenced this pull request Jul 24, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
@avivkeller

Copy link
Copy Markdown
Member

FYI in @node-core/doc-kit's web generator (the redesign), we completely support and recommend using this syntax (See: #62045)

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 force-pushed the stream_iter-no-ts-syntax branch from 53a84be to 662ed66 Compare July 24, 2026 17:39
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 24, 2026
@aduh95
aduh95 merged commit e8be132 into nodejs:main Jul 24, 2026
18 checks passed
@aduh95

aduh95 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Landed in e8be132

@aduh95
aduh95 deleted the stream_iter-no-ts-syntax branch July 24, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants