fix: add missing ESM/CJS tabs with their examples in Learn section#8619
Open
nitin-is-me wants to merge 1 commit intonodejs:mainfrom
Open
fix: add missing ESM/CJS tabs with their examples in Learn section#8619nitin-is-me wants to merge 1 commit intonodejs:mainfrom
nitin-is-me wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/diagnostics @nodejs/fs Please review the changes when you have a chance. Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR standardizes the code examples in en/learn section of the documentation to add the missing tabs for switching between ESM/CJS. I'd like to fix the other language docs as well whenever I get free time. Please do tell me if I missed any page in en/learn section.
Validation
Manually verified that cjs and mjs code blocks are strictly adjacent in the markdown, which is the requirement for rehype-shiki to render the tabs correctly. Here is the visual change (visible in all changes pages):
Original site:
Deployed preview site:
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.