Skip to content

fix: partial revert of 18cd69#9013

Open
avivkeller wants to merge 1 commit into
mainfrom
partial-revert-18cd69
Open

fix: partial revert of 18cd69#9013
avivkeller wants to merge 1 commit into
mainfrom
partial-revert-18cd69

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Fixes: #9012

Copilot AI review requested due to automatic review settings July 16, 2026 20:07
@avivkeller
avivkeller requested a review from a team as a code owner July 16, 2026 20:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cursor

cursor Bot commented Jul 16, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single CSS change in the article container with no auth, data, or API impact; layout-only fix with localized visual/scroll behavior.

Overview
Reverts part of the article layout sidebar sticky styling so the first column again uses top-0 and h-svh instead of offsetting below --header-height and using calc(100svh - var(--header-height)).

This partial rollback of commit 18cd69 restores the previous full-viewport sticky sidebar behavior on medium+ breakpoints, addressing nodejs.org#9012.

Reviewed by Cursor Bugbot for commit 9e57ea2. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 16, 2026 8:08pm

Request Review

@avivkeller

Copy link
Copy Markdown
Member Author

@bmuenzenmeyer can you set up changesets in this repo + require changes to ui-components to have a changeset?

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.59%. Comparing base (61cd932) to head (9e57ea2).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9013      +/-   ##
==========================================
+ Coverage   74.58%   74.59%   +0.01%     
==========================================
  Files         100      100              
  Lines        8801     8801              
  Branches      324      324              
==========================================
+ Hits         6564     6565       +1     
+ Misses       2233     2232       -1     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 10.70 MB
New Total First Load JS 10.70 MB
Delta 0 B (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression] Blank Space on Sidebar

4 participants