fix: show 404 page instead of blank on first visit to non-existent package#2777
fix: show 404 page instead of blank on first visit to non-existent package#27772u841r wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe package detail page restructures resolved-version fetching to defer client-side awaiting. ChangesResolved Version Conditional Awaiting and Loading State
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
previous one was mistakenly "closed by deleting the head repository 2 days ago" |
|
The description on #2733 (which this reopens) said the page stayed "completely blank until you refreshed." That's no longer quite accurate - retesting now, including with a genuinely never-queried, made-up package name, it still shows a blank flash (~200-300ms) before the 404 renders, but it resolves on its own without needing a manual refresh. So it's not just previously-queried names responding fast - even fresh, first-time lookups are quick now. The root cause described there is still accurate and still present: Fix itself is unchanged: skip the await on the client, let the server still await so 404 can throw synchronously, rely on the existing watch for the client error case, and show the skeleton while resolvedStatus is pending. |
Reopened from #2733.
previous one was mistakenly "closed by deleting the head repository 2 days ago"