Skip to content

fix: changelog - check release tag before title for deciding auto scroll. - #3305

Open
WilcoSp wants to merge 1 commit into
npmx-dev:mainfrom
WilcoSp:fix/use-tag-autoscroll
Open

WilcoSp wants to merge 1 commit into
npmx-dev:mainfrom
WilcoSp:fix/use-tag-autoscroll

Conversation

@WilcoSp

@WilcoSp WilcoSp commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

🔗 Linked issue

None

🧭 Context & 📚 Description

Before the auto scrolling at package changelog only used the release title for deciding where to auto scroll to, this pr adds checking the release tag and makes it the first to check.

This is most noticeable when viewing the changelogs for pnpm in the url hash.
here is an example with pnpm:

@agentscanapp

agentscanapp Bot commented Oct 4, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉

We really appreciate you taking the time to contribute, @WilcoSp.

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description explains what changed and why
  • any related issues are linked
  • existing tests still pass

If anything needs adjusting we'll leave comments here. Thanks again!

@vercel

vercel Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Oct 4, 2026 3:40pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Oct 4, 2026 3:40pm UTC
npmx-lunaria Ignored Ignored Oct 4, 2026 3:40pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a71dfa82-e8e1-4def-bdfd-1cee39182260
📥 Commits

Reviewing files that changed from the base of the PR and between 9900bc7 and 682b746.

📒 Files selected for processing (1)
  • app/components/Changelog/Releases.vue

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Release auto-scroll now finds releases by matching the requested version against either the release tag or title. Date-based navigation remains available when neither matches.

Walkthrough

Release auto-scroll now navigates to a release when its lower-cased tag or title contains goToVersion. Date-based navigation remains when neither matches.

Changes

Release navigation

Layer / File(s) Summary
Match release tags and titles
app/components/Changelog/Releases.vue
The version matcher checks the lower-cased release tag and title for goToVersion. If neither matches, the existing date-based navigation remains.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 682b7

Release auto-scroll now matches tags as well as titles, while preserving date-based navigation when neither matches. No concrete issue has been established, so the change appears ready to merge subject to normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 682b7

The change affects 1 system.

Changed systems: app

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — app (ui) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in app/components/Changelog/Releases.vue: The version match now checks whether either the lower-cased release tag or title contains goToVersion; previously, only the title was checked.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the change: check the release tag before the title when deciding where to auto-scroll.
Description check ✅ Passed The description explains the auto-scroll change and gives a relevant pnpm changelog example.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Changelog/Releases.vue 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

This branch was successfully deployed

1 active deployment
Preview – npmx.dev — 682b7461 Deployed Oct 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant