Skip to content

fix(i18n): use the placeholder names the code passes (lunaria-ignore) - #3311

Open
owgreen-dev wants to merge 1 commit into
npmx-dev:mainfrom
owgreen-dev:fix/i18n-renamed-placeholders
Open

owgreen-dev wants to merge 1 commit into
npmx-dev:mainfrom
owgreen-dev:fix/i18n-renamed-placeholders

Conversation

@owgreen-dev

Copy link
Copy Markdown

🔗 Linked issue

Closes #3310

📚 Description

The fix described in #3310.

@agentscanapp

agentscanapp Bot commented Oct 6, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉

We really appreciate you taking the time to contribute, @owgreen-dev.

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description explains what changed and why
  • any related issues are linked
  • existing tests still pass

If anything needs adjusting we'll leave comments here. Thanks again!

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Oct 6, 2026 10:03am UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Oct 6, 2026 10:03am UTC
npmx-lunaria Ignored Ignored Oct 6, 2026 10:03am UTC

Request Review

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the tracking.ignoredKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ar-EG.json Localization changed, will be marked as complete.
i18n/locales/de.json Localization changed, will be marked as complete.
i18n/locales/nl.json Localization changed, will be marked as complete.
i18n/locales/pl-PL.json Localization changed, will be marked as complete.
i18n/locales/ro-RO.json Localization changed, will be marked as complete.
i18n/locales/tr-TR.json Localization changed, will be marked as complete.
i18n/locales/zh-TW.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dde1a0ae-c459-49ea-a7da-ebf9b2452135
📥 Commits

Reviewing files that changed from the base of the PR and between 9900bc7 and 18b504e.

📒 Files selected for processing (7)
  • i18n/locales/ar-EG.json
  • i18n/locales/de.json
  • i18n/locales/nl.json
  • i18n/locales/pl-PL.json
  • i18n/locales/ro-RO.json
  • i18n/locales/tr-TR.json
  • i18n/locales/zh-TW.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Corrected translated labels and descriptions across Arabic, German, Dutch, Polish, Romanian, Turkish and Traditional Chinese.
    • Updated displayed package, version, pagination, search, chart and vulnerability details to use the correct values.

Walkthrough

Translation strings in seven locales now use interpolation placeholders that match the values supplied by the application. The Turkish invitation and vulnerability strings and the Arabic anomaly-range string also have updated wording.

Changes

Locale interpolation updates

Layer / File(s) Summary
Profile, invitation and anomaly strings
i18n/locales/ar-EG.json, i18n/locales/tr-TR.json
Profile SEO strings use {handle}. The Turkish invitation string includes the handle, and both locales use package names in named anomaly strings.
Counts and package labels
i18n/locales/tr-TR.json, i18n/locales/nl.json
Turkish count and pagination strings use updated placeholders. The Turkish package-removal and vulnerability strings use the supplied values. Dutch pagination uses {range}.
Settings, accessibility and chart strings
i18n/locales/de.json, i18n/locales/nl.json, i18n/locales/pl-PL.json, i18n/locales/ro-RO.json, i18n/locales/zh-TW.json
The settings, accessibility, chart and tooltip strings use updated interpolation placeholders.

Suggested reviewers: btea

Priority: ➖ Normal

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 18b50

The translation updates appear ready to merge after normal checks; no actionable interpolation mismatch remains identified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #3310 requires correcting locale placeholders to match values supplied by the code. The diff updates the listed placeholders across ar-EG, de, nl, pl-PL, ro-RO, tr-TR and zh-TW. It also revises …
Out of Scope Changes check ✅ Passed All changes are locale string edits tied to the placeholder and wording corrections in issue #3310. The diff shows no unrelated changes.
Title check ✅ Passed The title clearly identifies the main change: correcting translation placeholder names to match those passed by the code.
Description check ✅ Passed The description links to issue #3310 and states that this pull request implements its fix. This relates to the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@owgreen-dev owgreen-dev changed the title fix(i18n): use the placeholder names the code passes fix(i18n): use the placeholder names the code passes (lunaria-ignore) Oct 6, 2026
@WilcoSp

WilcoSp commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

hey nice that you caught these. with NL with {instellingen} I did also caught it and also fixed it at #3283.
with {range} I didn't notice it was changed, hopefully #1761 will eventually fix it

at least with Dutch (nl) you've a ✅ from me

This branch was successfully deployed

1 active deployment
Preview – npmx.dev — 18b504e0 Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 translations use placeholder names that the code never passes, values are blank

2 participants