Skip to content

docs(ui): add stories for Sponsors page - #3312

Open
IestynGage wants to merge 1 commit into
npmx-dev:mainfrom
IestynGage:main
Open

IestynGage wants to merge 1 commit into
npmx-dev:mainfrom
IestynGage:main

Conversation

@IestynGage

@IestynGage IestynGage commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

For some reason when I first load the page in storybook, it seems like some of the CSS hasn't fully loaded. Refreshing the page seems to fix it. I think this is a bug with storybook or my setup TBH

Well it seems to render just fine on chromatic 🤷

🔗 Linked issue

#2150 Pages missing Storybook stories

🧭 Context

The issue #2150 doesn't request adding a storybook for this page specifically, but it is missing and the sponsors page was added after this issue was created.

📚 Description

Adds a storybook for the sponsors page.

For some reason why I first load the page in storybook,
it seems like some of the CSS hasn't fully loaded.
Reloading the page seemed to fix it.

I think this is a bug with storybook or my setup TBH
@agentscanapp

agentscanapp Bot commented Oct 6, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉

We really appreciate you taking the time to contribute, @IestynGage.

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description explains what changed and why
  • any related issues are linked
  • existing tests still pass

If anything needs adjusting we'll leave comments here. Thanks again!

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Oct 6, 2026 10:21pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Oct 6, 2026 10:21pm UTC
npmx-lunaria Ignored Ignored Oct 6, 2026 10:21pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ea301e69-77db-4bef-8ed9-bbda8848e8ab
📥 Commits

Reviewing files that changed from the base of the PR and between 9900bc7 and ac4c260.

📒 Files selected for processing (1)
  • app/pages/sponsors.stories.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Added a Storybook example showing the Sponsors page in a full-screen layout.

Walkthrough

The change adds Storybook metadata and a default story for the Sponsors component. The story uses the fullscreen layout and pageDecorator.

Changes

Sponsors Storybook story

Layer / File(s) Summary
Sponsors story setup
app/pages/sponsors.stories.ts
Adds component metadata with fullscreen layout and pageDecorator. Exports an empty Default story.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ac4c2

The story is mergeable after normal checks. The reported first-load styling behavior remains worth checking, but there is no evidence that this change causes it.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the addition of a Storybook story for the Sponsors page.
Description check ✅ Passed The description explains the Sponsors page story and its context, including the reported first-load CSS issue.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/sponsors.stories.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

This branch was successfully deployed

1 active deployment
Preview – npmx.dev — ac4c2604 Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant