Skip to content

Return status 405 when router error was ErrMethodNotAllowed #12

Open
Open
Return status 405 when router error was ErrMethodNotAllowed#12

Description

@strowk
strowk
opened on Jan 30, 2024

I think it could be convenient impovement here. Currently 404 is coded for all router errors.

See example how it is done in another lib:
https://github.com/getkin/kin-openapi/blob/529285c16a9d45f7f908c1d61e67abcc070d192f/openapi3filter/validation_error_encoder.go#L55-L57

Place to put it here:

echo-middleware/oapi_validate.go

Lines 119 to 122 in b1361c4

case *routers.RouteError:
// We've got a bad request, the path requested doesn't match
// either server, or path, or something.
return echo.NewHTTPError(http.StatusNotFound, e.Reason)

Activity

  1. strowk
    changed the title [-]Return status 405 when router error was MethodNotAllowed[/-] [+]Return status 405 when router error was ErrMethodNotAllowed[/+] on Jan 30, 2024
  2. florentchauveau
    added a commit that references this issue on Jan 5, 2025

    Fixes oapi-codegen#12

    e592981
  3. jamietanna
    added this to Issues for all middlewareon Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions