You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 22, 2023. It is now read-only.
My team has a use case where we are attempting to bundle our Oclif command. This provides us some benefits:
If there are fewer files that we need to call chmod on, we can effectively reduce the install time for Homebrew, which needs to make the files executable.
We want to test any performance gains from tree-shaking and minification
We noticed that once we bundled a command, we encountered the error:
Error: Cannot find module '/Users/lshadler/Documents/personal-workspace/dev-cli/lib/package.json'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
at Function.Module._load (internal/modules/cjs/loader.js:562:25)
at Module.require (internal/modules/cjs/loader.js:692:17)
at require (internal/modules/cjs/helpers.js:25:18)
at checkNodeVersion (/dev/dev-cli/lib/commands/hello.js:156917:19)
at __commonJS (/dev/dev-cli/lib/commands/hello.js:156927:3)
at /dev/dev-cli/lib/commands/hello.js:11:5
at Object.<anonymous> (/dev/dev-cli/lib/commands/hello.js:156942:28)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
This change adjusts the package resolution to bubble up to the nearest package.json instead of short-circuiting to '..'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My team has a use case where we are attempting to bundle our Oclif command. This provides us some benefits:
chmodon, we can effectively reduce the install time for Homebrew, which needs to make the files executable.We noticed that once we bundled a command, we encountered the error:
This change adjusts the package resolution to bubble up to the nearest
package.jsoninstead of short-circuiting to'..'