Skip to content

Fix/hybrid search#26560

Merged
pmbrull merged 18 commits intomainfrom
fix/hybrid-search
Mar 19, 2026
Merged

Fix/hybrid search#26560
pmbrull merged 18 commits intomainfrom
fix/hybrid-search

Conversation

@lautel
Copy link
Contributor

@lautel lautel commented Mar 17, 2026

Add option to filter by databaseSchema.name in semantic search

@lautel lautel self-assigned this Mar 17, 2026
@lautel lautel added the safe to test Add this label to run secure Github workflows on PRs label Mar 17, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

🟡 Playwright Results — all passed (14 flaky)

✅ 3390 passed · ❌ 0 failed · 🟡 14 flaky · ⏭️ 183 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 453 0 2 2
✅ Shard 2 305 0 0 1
🟡 Shard 3 668 0 5 33
🟡 Shard 4 681 0 4 41
✅ Shard 5 672 0 0 73
🟡 Shard 6 611 0 3 33
🟡 14 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Stored Procedure - customization should work (shard 1, 1 retry)
  • Features/MetricCustomUnitFlow.spec.ts › Should create metric and test unit of measurement updates (shard 1, 1 retry)
  • Features/BulkImport.spec.ts › Database (shard 3, 1 retry)
  • Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit icon on incidents (shard 3, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 3, 1 retry)
  • Features/ImpactAnalysis.spec.ts › Verify column level upstream connections (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DomainDataProductsRightPanel.spec.ts › Should edit owners for data product from domain context (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Data Product announcement create, edit & delete (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Comprehensive domain rename with ALL relationships preserved (shard 4, 1 retry)
  • Pages/Lineage.spec.ts › Lineage creation from Metric entity (shard 6, 1 retry)
  • Pages/UserDetails.spec.ts › Create team with domain and verify visibility of inherited domain in user profile after team removal (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link

gitar-bot bot commented Mar 18, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Hybrid search fix adds databaseSchema to VectorSearchQueryBuilder and reverts nested type application to tags in test_case_index_mapping. No issues found.

✅ 1 resolved
Bug: databaseSchema filter misses displayName unlike database

📄 openmetadata-service/src/main/java/org/openmetadata/service/search/vector/VectorSearchQueryBuilder.java:121-124 📄 openmetadata-service/src/main/java/org/openmetadata/service/search/vector/VectorSearchQueryBuilder.java:117-120
The new databaseSchema case uses appendFlat(sb, "databaseSchema.name", values), but the analogous database case uses appendFlatOr(sb, "database.name", "database.displayName", values) to match on both name and displayName. The index mapping for databaseSchema does include a displayName field (confirmed in table_index_mapping.json), so users filtering by a schema's display name will get no results in vector/hybrid search.

This is likely an oversight — the fix should mirror the database pattern.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link

@pmbrull pmbrull merged commit b278c74 into main Mar 19, 2026
42 of 43 checks passed
@pmbrull pmbrull deleted the fix/hybrid-search branch March 19, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants