Add file configuration types for Tracer, Meter, and Logger#3920
Open
UMMAN2005 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Add file configuration types for Tracer, Meter, and Logger#3920UMMAN2005 wants to merge 2 commits intoopen-telemetry:mainfrom
UMMAN2005 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3920 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 226 226
Lines 7223 7223
=======================================
Hits 6504 6504
Misses 719 719 🚀 New features to boost your workflow:
|
UMMAN2005
force-pushed
the
feature/file-config-tracer-meter-logger
branch
from
61e4ad7 to
d71a591
Compare
Implement ExperimentalTracerConfig, ExperimentalTracerConfigurator, ExperimentalTracerMatcherAndConfig and their Meter/Logger equivalents as defined in the declarative configuration spec. - Add 9 new configuration model headers (Config, MatcherAndConfig, Configurator for each signal) - Wire configurator fields into TracerProviderConfiguration, MeterProviderConfiguration, and LoggerProviderConfiguration - Implement YAML parsing for the new configuration types in ConfigurationParser - Add ScopeConfigurator creation with wildcard name matching in SdkBuilder - Add unit tests for parsing the new configurator sections Resolves open-telemetry#3915
UMMAN2005
force-pushed
the
feature/file-config-tracer-meter-logger
branch
from
d71a591 to
a6ad72d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the file configuration types for Tracer, Meter, and Logger as described in #3915.
Changes
ExperimentalTracerConfig,ExperimentalTracerMatcherAndConfig,ExperimentalTracerConfigurator(and their Meter/Logger equivalents), following the project's one-class-per-header convention.FIXMEcomments inTracerProviderConfiguration,MeterProviderConfiguration, andLoggerProviderConfigurationwith the new configurator fields.tracer_configurator/development,meter_configurator/development, andlogger_configurator/developmentsections inConfigurationParser.CreateTracerConfigurator,CreateMeterConfigurator,CreateLoggerConfiguratorinSdkBuilderto constructScopeConfigurator<T>objects from parsed configuration, including wildcard name matching (?and*).yaml_trace_test.cc,yaml_metrics_test.cc, andyaml_logs_test.cc.Types implemented
Test plan
Resolves #3915