[CODE HEALTH] Fix clang-tidy bugprone-exception-escape warnings in API

api/include/opentelemetry/common/kv_properties.h

@@ -49,56 +49,67 @@ class KeyValueStringTokenizer
   // @returns true if next kv pair was found, false otherwise.
   bool next(bool &valid_kv, nostd::string_view &key, nostd::string_view &value) noexcept
   {
-    valid_kv = true;
-    while (index_ < str_.size())
+#if OPENTELEMETRY_HAVE_EXCEPTIONS
+    try
+#endif
     {
-      bool is_empty_pair = false;
-      size_t end         = str_.find(opts_.member_separator, index_);
-      if (end == std::string::npos)
-      {
-        end = str_.size() - 1;
-      }
-      else if (end == index_)  // empty pair. do not update end
-      {
-        is_empty_pair = true;
-      }
-      else
-      {
-        end--;
-      }
-
-      auto list_member = StringUtil::Trim(str_, index_, end);
-      if (list_member.size() == 0 || is_empty_pair)
+      valid_kv = true;
+      while (index_ < str_.size())
       {
-        // empty list member
-        index_ = end + 2 - is_empty_pair;
-        if (opts_.ignore_empty_members)
+        bool is_empty_pair = false;
+        size_t end         = str_.find(opts_.member_separator, index_);
+        if (end == std::string::npos)
+        {
+          end = str_.size() - 1;
+        }
+        else if (end == index_)  // empty pair. do not update end
         {
-          continue;
+          is_empty_pair = true;
+        }
+        else
+        {
+          end--;
         }
 
-        valid_kv = true;
-        key      = GetDefaultKeyOrValue();
-        value    = GetDefaultKeyOrValue();
-        return true;
-      }
+        auto list_member = StringUtil::Trim(str_, index_, end);
+        if (list_member.size() == 0 || is_empty_pair)
+        {
+          // empty list member
+          index_ = end + 2 - is_empty_pair;
+          if (opts_.ignore_empty_members)
+          {
+            continue;
+          }
+
+          valid_kv = true;
+          key      = GetDefaultKeyOrValue();
+          value    = GetDefaultKeyOrValue();
+          return true;
+        }
 
-      auto key_end_pos = list_member.find(opts_.key_value_separator);
-      if (key_end_pos == std::string::npos)
-      {
-        // invalid member
-        valid_kv = false;
-      }
-      else
-      {
-        key   = list_member.substr(0, key_end_pos);
-        value = list_member.substr(key_end_pos + 1);
-      }
+        auto key_end_pos = list_member.find(opts_.key_value_separator);
+        if (key_end_pos == std::string::npos)
+        {
+          // invalid member
+          valid_kv = false;
+        }
+        else
+        {
+          key   = list_member.substr(0, key_end_pos);
+          value = list_member.substr(key_end_pos + 1);
+        }
 
-      index_ = end + 2;
+        index_ = end + 2;
 
-      return true;
+        return true;
+      }
+    }
+#if OPENTELEMETRY_HAVE_EXCEPTIONS
+    catch (...)
+    {
+      return false;
     }
+#endif
 
     // no more entries remaining
     return false;

api/include/opentelemetry/common/string_util.h

@@ -5,6 +5,7 @@
 
 #include <ctype.h>
 
+#include "opentelemetry/common/macros.h"
 #include "opentelemetry/nostd/string_view.h"
 #include "opentelemetry/version.h"
 
@@ -25,7 +26,18 @@ class StringUtil
     {
       right--;
     }
-    return str.substr(left, 1 + right - left);
+#if OPENTELEMETRY_HAVE_EXCEPTIONS
+    try
+#endif
+    {
+      return str.substr(left, 1 + right - left);
+    }
+#if OPENTELEMETRY_HAVE_EXCEPTIONS
+    catch (...)
+    {
+      return nostd::string_view();
+    }
+#endif
   }
 
   static nostd::string_view Trim(nostd::string_view str) noexcept

api/include/opentelemetry/nostd/string_view.h

@@ -71,7 +71,7 @@ class string_view
   {
     if (pos > length_)
     {
-#  if __EXCEPTIONS
+#  if OPENTELEMETRY_HAVE_EXCEPTIONS
       throw std::out_of_range{"opentelemetry::nostd::string_view"};
 #  else
       std::terminate();

api/include/opentelemetry/nostd/variant.h

@@ -18,7 +18,7 @@
 // Header-only. Without compiling the actual Abseil binary. As Abseil moves on to new
 // toolchains, it may drop support for Visual Studio 2015 in future versions.
 
-#  if defined(__EXCEPTIONS)
+#  if OPENTELEMETRY_HAVE_EXCEPTIONS
 #    include <exception>
 OPENTELEMETRY_BEGIN_NAMESPACE
 namespace nostd

api/include/opentelemetry/plugin/detail/utility.h

@@ -3,36 +3,34 @@
 
 #pragma once
 
-#if __EXCEPTIONS
-#  include <new>
-#endif  // __EXCEPTIONS
+#include "opentelemetry/version.h"
 
 #include <string>
 
-#include "opentelemetry/version.h"
-
 OPENTELEMETRY_BEGIN_NAMESPACE
 namespace plugin
 {
 namespace detail
 {
 inline void CopyErrorMessage(const char *source, std::string &destination) noexcept
-#if __EXCEPTIONS
-try
-#endif
 {
-  if (source == nullptr)
+#if OPENTELEMETRY_HAVE_EXCEPTIONS
+  try
+#endif
+  {
+    if (source == nullptr)
+    {
+      return;
+    }
+    destination.assign(source);
+  }
+#if OPENTELEMETRY_HAVE_EXCEPTIONS
+  catch (...)
   {
     return;
   }
-  destination.assign(source);
-}
-#if __EXCEPTIONS
-catch (const std::bad_alloc &)
-{
-  return;
-}
 #endif
+}
 }  // namespace detail
 }  // namespace plugin
 OPENTELEMETRY_END_NAMESPACE

api/include/opentelemetry/std/variant.h

@@ -33,7 +33,7 @@ using monostate = std::monostate;
 // Apple Platforms provide std::bad_variant_access only in newer versions of OS.
 // To keep API compatible with any version of OS - we are providing our own
 // implementation of nostd::bad_variant_access exception.
-#  if __EXCEPTIONS
+#  if OPENTELEMETRY_HAVE_EXCEPTIONS
 
 // nostd::bad_variant_access
 class bad_variant_access : public std::exception
@@ -48,7 +48,7 @@ class bad_variant_access : public std::exception
 }
 #  endif
 
-#  if __EXCEPTIONS
+#  if OPENTELEMETRY_HAVE_EXCEPTIONS
 #    define THROW_BAD_VARIANT_ACCESS throw_bad_variant_access()
 #  else
 #    define THROW_BAD_VARIANT_ACCESS std::terminate()