[CI] Update ci scripts and documentation#4000
Conversation
…used legacy targets. Ensure bazel tests and cmake tests can be run in the development container. Update documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4000 +/- ##
==========================================
- Coverage 90.33% 90.32% -0.01%
==========================================
Files 230 230
Lines 7299 7299
==========================================
- Hits 6593 6592 -1
- Misses 706 707 +1 🚀 New features to boost your workflow:
|
|
|
||
| RUN git config --global core.autocrlf input \ | ||
| && chmod +x /usr/local/bin/bazelisk-linux-amd64 | ||
| RUN cd /opt/ci && bash install_bazelisk.sh |
There was a problem hiding this comment.
nit: since install_bazelisk.sh accepts a version argument, should we pass v1.22.1 here to preserve the previous devcontainer Bazelisk version? Otherwise this looks like a downgrade.
There was a problem hiding this comment.
Good question. My intent is to try to bring the dev environment closer to the ci environment with this change. All the ci workflows currently use the default version of the script. How about a separate PR for the upgrade?
There was a problem hiding this comment.
Script ./ci/install_bazelisk.sh does not take a version as argument, it hard code version v1.16.0.
But I can not find where install_bazelisk.sh is used from today.
There was a problem hiding this comment.
it's currently only used by the bazel jobs in the ci and benchmark workflows.
There was a problem hiding this comment.
How about a separate PR for the upgrade?
Sounds good to me
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
Thanks. LGTM, with nit comment/
| sed -i "s~gRPC_CPP_PLUGIN_EXECUTABLE-NOTFOUND~$grpc_cpp_plugin~" ${proto_make_file} #fixme | ||
| make -j $(nproc) | ||
| cd exporters/otlp && make test | ||
| cmake --build . "${CMAKE_BUILD_ARGS[@]}" |
There was a problem hiding this comment.
This runs under the boot root now which was exportes/otlp, does it increase the test code to be out of cmake.exporter.otprococol.*?
There was a problem hiding this comment.
With this change it does run all the tests built. Before all the tests were built but only the otlp tests were run.
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the cleanup.
[CI] Update ci scripts and documentation (open-telemetry#4000)
4 participants
Contributes to #3999
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes