translate /development in DeclarativeConfigPropertiesBridge
#15606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
commented
Dec 11, 2025
|
|
||
| // experimental in the middle of the property name should be preserved | ||
| assertThat( | ||
| bridge.getBoolean("otel.instrumentation.runtime-telemetry.emit-experimental-telemetry")) |
Member
Author
There was a problem hiding this comment.
it's really only this setting - so we can define a custom mapping like emit-experimental-telemetry/development
Member
Author
There was a problem hiding this comment.
I just added this mapping
github-actions
bot
added
the
test native
laurit
reviewed
Dec 11, 2025
...n/java/io/opentelemetry/instrumentation/config/bridge/DeclarativeConfigPropertiesBridge.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@trask I think at this point, you're faster to get rid of DeclarativeConfigPropertiesBridge - so this isn't needed any more 😄 |
github-project-automation
bot
moved this from Awaiting Review
to Done
in Declarative Configuration: Java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15339