Add toString to ComposableAnnotatingSampler#8645
Draft
thswlsqls wants to merge 1 commit into
Draft
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-20 21:23:42 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, report it with the result you expected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8645 +/- ##
=========================================
Coverage 91.64% 91.64%
- Complexity 10348 10349 +1
=========================================
Files 1013 1013
Lines 27380 27381 +1
Branches 3218 3218
=========================================
+ Hits 25092 25093 +1
Misses 1558 1558
Partials 730 730 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8644
Description
ComposableAnnotatingSamplerwas the only one of the sevenComposableSamplerimplementations without atoString()override that returnsgetDescription().ComposableParentThresholdSamplerbuilds its description by concatenating its root sampler, so composing it with an annotating sampler surfaced anObjecthash (ComposableAnnotatingSampler@1a2b3c) in the observablegetDescription()output.Testing done
ComposableAnnotatingSamplerTest#descriptionInComposedSamplerasserting the composedparentThreshold(annotating(...))description contains the real annotating description and no@object hash — RED before the fix, GREEN after../gradlew :sdk-extensions:incubator:check— passed.-alphamodule; nodocs/apidiffs/change.