-
Notifications
You must be signed in to change notification settings - Fork 831
HTTP semantic convention stability migration for aiohttp-server #3980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
HTTP semantic convention stability migration for aiohttp-server #3980
Conversation
...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py
Outdated
Show resolved
Hide resolved
...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py
Outdated
Show resolved
Hide resolved
...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py
Outdated
Show resolved
Hide resolved
...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py
Outdated
Show resolved
Hide resolved
...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py
Outdated
Show resolved
Hide resolved
|
Left a few more small comments, otherwise LGTM |
emdneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tammy-baylis-swi, this is awesome. Overall LGTM. Would you mind adding this
_semconv_status = "migration"
to package.py for aiohttp-server instrumentation?
| _set_http_flavor_version(result, flavor, sem_conv_opt_in_mode) | ||
|
|
||
| if _report_old(sem_conv_opt_in_mode): | ||
| result[HTTP_ROUTE] = _get_view_func(request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while since I reviewed the HTTP semconv migration docs, so I may be missing something, but shouldn't HTTP_ROUTE also be set in the stable version of the semantic convention? https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we assert the schema_url in tests?
Description
Adds HTTP semantic convention stability migration / opt-in for
opentelemetry-instrumentation-aiohttp-server.Fixes #3981
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
http, andhttp/dupDefault span attributes
httpspan attributeshttp/duphas both sets.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.