Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5893.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-sdk`: use unit `{log_record}` and update description for `otel.sdk.processor.log.queue.size`
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,10 @@ def record_queue_size(
queue_size_unit = "{span}"
else:
queue_size_name = OTEL_SDK_PROCESSOR_LOG_QUEUE_SIZE
queue_size_description = "The number of logs in the queue of a given instance of an SDK log processor."
queue_size_unit = "{log}"
queue_size_description = (
"The number of log records in the queue of a given instance of an SDK log processor."
)
queue_size_unit = "{log_record}"

self._meter.create_observable_up_down_counter(
queue_size_name,
Expand Down
10 changes: 10 additions & 0 deletions opentelemetry-sdk/tests/logs/test_export.py
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,11 @@ def export_logs(_logs):
queue_capacity_data_point.attributes["otel.component.name"].startswith("batching_log_processor/")
)
self.assertEqual(metrics[2].name, "otel.sdk.processor.log.queue.size")
self.assertEqual(metrics[2].unit, "{log_record}")
self.assertEqual(
metrics[2].description,
"The number of log records in the queue of a given instance of an SDK log processor.",
)
queue_size_data_point = metrics[2].data.data_points[0]
self.assertEqual(queue_size_data_point.value, 1)
self.assertEqual(
Expand Down Expand Up @@ -811,6 +816,11 @@ def export_logs(_logs):
queue_capacity_data_point.attributes["otel.component.name"].startswith("batching_log_processor/")
)
self.assertEqual(metrics[2].name, "otel.sdk.processor.log.queue.size")
self.assertEqual(metrics[2].unit, "{log_record}")
self.assertEqual(
metrics[2].description,
"The number of log records in the queue of a given instance of an SDK log processor.",
)
queue_size_data_point = metrics[2].data.data_points[0]
self.assertEqual(queue_size_data_point.value, 0)
self.assertEqual(
Expand Down