docs: fix claude authentication command#739
Conversation
Replace `claude setup-token` with `claude auth login` for container auth. `claude setup-token` generates a long-lived token for CI/scripts without saving it locally. For container deployments with PVC persistence, `claude auth login` is the correct command — it authenticates via OAuth device flow and stores credentials on disk. Ref: https://docs.anthropic.com/en/docs/claude-code/cli-usage
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
OpenAB PR ScreeningThis is auto-generated by the OpenAB project-screening flow for context collection and reviewer handoff.
Screening report## IntentPR #739 updates The operator-visible problem is that the docs currently tell deployers to run FeatDocs improvement. The PR replaces the Claude authentication instruction with Who It ServesPrimary beneficiary: deployers and agent runtime operators running OpenAB with Claude Code in containers. Secondary beneficiaries: maintainers and reviewers, because the documented setup path becomes less error-prone and better aligned with persistent runtime environments. Rewritten PromptUpdate Make the docs clearly distinguish:
Keep the change scoped to documentation. Verify the surrounding setup instructions still read coherently for a deployer following the container/PVC flow. Merge PitchThis is a low-risk documentation correction that prevents operators from following an authentication path poorly suited to persistent container deployments. It is worth advancing because incorrect auth setup can cause avoidable runtime failures after pod restarts. Likely reviewer concern: whether Best-Practice ComparisonRelevant OpenClaw principles:
Relevant Hermes Agent principles:
The proposed direction fits the persistence-oriented parts of both systems: runtime state that must survive restarts should be stored deliberately, not emitted once to stdout and left to manual handling. Implementation OptionsConservative option: merge the current one-line command replacement plus minimal explanatory text. Balanced option: merge the command replacement and add a short note explaining when to use Ambitious option: expand Comparison Table
RecommendationAdvance the PR with the balanced documentation shape. The command correction is clearly useful, but the merge is stronger if the docs explicitly preserve Suggested sequencing: merge this as a focused docs fix, then split any broader Claude Code deployment troubleshooting into a separate follow-up if maintainers want more complete operator guidance. |
PR Review: #739Based on commit: Summary
Core Assessment
Fact VerificationI checked the official Claude Code CLI reference:
PR claims are consistent with official docs ✅ Findings🟢 INFO
🔴 SUGGESTED CHANGE — Incomplete scope The repo has two other locations that still reference
If only
🟡 NIT — Minor wording The phrase "restart the pod to pick up the new credentials" is slightly imprecise. After VerdictCOMMENT — The fix itself is correct and valuable, but the scope should be discussed. The other two references to |
Address review comments: - Replace claude setup-token with claude auth login in NOTES.txt - Replace claude setup-token with claude auth login in wizard.rs - Improve wording: 'restart the pod so the bot process loads the new credentials'
Summary
Replace
claude setup-tokenwithclaude auth loginindocs/claude-code.md.Problem
The doc previously instructed users to run
claude setup-tokenfor authentication. This command generates a long-lived token and prints it to stdout without saving it locally — it is intended for CI/scripts where you setCLAUDE_CODE_OAUTH_TOKENas an env var.For container deployments with PVC persistence,
claude auth loginis the correct command. It authenticates via OAuth device flow and stores credentials on disk, surviving pod restarts.Reference
From the official Claude Code CLI reference:
claude setup-token— "Generate a long-lived OAuth token for CI and scripts. Prints the token to the terminal without saving it."claude auth login— "Sign in to your Anthropic account." (stores credentials locally)For container deployments with PVC persistence,
claude auth loginis the correct command.