Gracefully drain exec-server on shutdown signals#20534
Draft
starr-openai wants to merge 4 commits intomainfrom
Draft
Gracefully drain exec-server on shutdown signals#20534starr-openai wants to merge 4 commits intomainfrom
starr-openai wants to merge 4 commits intomainfrom
Conversation
starr-openai
force-pushed
the
starr/exec-server-graceful-drain
branch
from
5fb4ab9 to
ee3399d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fb4ab9905
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
starr-openai
force-pushed
the
starr/exec-server-graceful-drain
branch
from
ee3399d to
f6b3eec
Compare
Add dedicated exec-server shutdown config and signal handling so the listener stops accepting new websocket connections while existing work drains up to a configurable timeout. Reject new process starts and HTTP requests once drain begins, and force remaining sessions on timeout or a second signal. Add focused config, CLI, and signal shutdown tests for drain, timeout, second signal, and new connection/start rejection behavior. Co-authored-by: Codex <noreply@openai.com>
starr-openai
force-pushed
the
starr/exec-server-graceful-drain
branch
from
f6b3eec to
6220442
Compare
starr-openai
changed the title
Reap completed websocket connection tasks while serving so long-running exec-server processes do not retain finished JoinSet entries. Track all in-flight JSON-RPC request handlers in the drain state before declaring shutdown idle, covering non-process/non-http RPCs as well as the existing process and HTTP drain checks. Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
just fmtbazel test --bes_backend= --bes_results_url= //codex-rs/exec-server:exec-server-unit-tests //codex-rs/exec-server:exec-server-websocket-test //codex-rs/exec-server:exec-server-shutdown-test //codex-rs/cli:cli-unit-tests