app-server: move transport into dedicated crate#20545
Merged
euroelessar merged 3 commits intomainfrom May 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b5d7d0bc8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
owenlin0
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex-app-servercurrently owns both request-processing code and transport implementation details. Splitting the transport layer into its own crate makes that boundary explicit, reduces the amount of transport-specific dependency surface carried bycodex-app-server, and gives future transport work a narrower place to evolve.What changed
codex-app-server-transportand moved the existing transport tree into it, including stdio, unix socket, websocket, remote-control transport, and websocket auth.codex-app-serveruse the same definitions.codex-app-server, with the routing tests moved next to that local wrapper.codex-app-serverdependencies for the new crate boundary.Validation
cargo metadata --locked --no-depsgit diff --checkcargo test -p codex-app-server-transport,cargo test -p codex-app-server,just fix -p codex-app-server-transport, andjust fix -p codex-app-server; all were blocked before compilation by the existingpackageproxyresolution failure for lockedrustls-webpki = 0.103.13.v8.