Enforce animations = false for screen readers#20564
Open
etraut-openai wants to merge 2 commits intomainfrom
Open
Enforce animations = false for screen readers#20564etraut-openai wants to merge 2 commits intomainfrom
animations = false for screen readers#20564etraut-openai wants to merge 2 commits intomainfrom
Conversation
Add a central motion helper and source scan so direct spinner/shimmer use goes through reduced-motion fallbacks.\n\nRefs #20489
animations = false for screen readers
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
May 1, 2026
…ini-cli) - openai/codex#20564 — Enforce animations=false for screen readers (merge-as-is) - openai/codex#20530 — Support multi-env filesystem tools (merge-after-nits) - BerriAI/litellm#26956 — Fix MCP semantic filter native tool passthrough (merge-after-nits) - google-gemini/gemini-cli#26277 — docs(sdk): add JSDoc to all exports (merge-as-is)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #20489 calls out that animated TUI affordances can be noisy for screen-reader users. Codex already has
tui.animations = falseas a reduced-motion setting, but some live activity rows render spinner-style prefixes in that mode. These were relatively recent regressions.We have also regressed this pattern more than once by adding new spinner/shimmer callsites that do not think through the reduced-motion path, so this PR adds a small guardrail while fixing the current surfaces.
What changed
Working (...).tui/src/motion.rs, with explicit reduced-motion choices for hidden prefixes, static bullets, and plain shimmer-text fallbacks.spinner(...)orshimmer_spans(...)usage outside the central module and primitive definition.Verification
cargo test -p codex-tui